Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: internals.construction #40154

Merged
merged 11 commits into from
Mar 3, 2021
Merged

TYP: internals.construction #40154

merged 11 commits into from
Mar 3, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jorisvandenbossche
Copy link
Member

Would it be OK to wait on #39991 for this?

@jbrockmendel
Copy link
Member Author

Would it be OK to wait on #39991 for this?

should be OK

@jreback jreback added Constructors Series/DataFrame/Index/pd.array Constructors Typing type annotations, mypy/pyright type checking labels Mar 2, 2021
@jreback jreback added this to the 1.3 milestone Mar 2, 2021
@jorisvandenbossche
Copy link
Member

Thanks, #39991 is merged now

@jbrockmendel
Copy link
Member Author

updated, should fix the mypy complaint that made it into master

jorisvandenbossche
jorisvandenbossche reviewed Mar 3, 2021
View reviewed changes
pandas/core/frame.py

elif isinstance(data, (np.ndarray, DataFrame)):
arrays, columns = to_arrays(data, columns)
if columns is not None:
columns = ensure_index(columns)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ensured by to_arrays already?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

jorisvandenbossche
jorisvandenbossche reviewed Mar 3, 2021
View reviewed changes
pandas/core/internals/construction.py Outdated
@@ -91,7 +92,7 @@ def arrays_to_mgr(
dtype: Optional[DtypeObj] = None,
verify_integrity: bool = True,
typ: Optional[str] = None,
):
) -> Union[BlockManager, ArrayManager]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typing alias for this union (Manager, I think)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind keeping this for a follow-up? id like to get the CI back to green

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI checks are also still failing on this PR

@jbrockmendel
Copy link
Member Author

this now gets the code checks passing (just the bs4 thing left)

@jorisvandenbossche jorisvandenbossche merged commit 440a7de into pandas-dev:master Mar 3, 2021
@jorisvandenbossche
Copy link
Member

Thanks!

@jbrockmendel jbrockmendel deleted the typ-reorder_arrays branch March 3, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jorisvandenbossche @jreback