-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REG: read_excel with engine specified raises on non-path/non-buffer #39586
Merged
+62
−19
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b887183
REG: read_excel with engine specified raises on non-path/non-buffer
rhshadrach 2291988
Merge branch 'master' of https://github.com/pandas-dev/pandas into op…
rhshadrach 601ad87
Restore special-casing for xlrd.Book even when engine is None
rhshadrach d835dff
GH # in test
rhshadrach e6684e9
Added wb.close() to test
rhshadrach 1f16602
Merge branch 'master' of https://github.com/pandas-dev/pandas into op…
rhshadrach ba2bc75
Added logic/tests for determining if a sheet is read-only
rhshadrach 1381ecc
Added comment
rhshadrach a3db3eb
Combine and reorg tests
rhshadrach 33acfaa
Only mark as xfail for read-only cases
rhshadrach 224d2a1
fixup
rhshadrach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added wb.close() to test
commit e6684e9a0f0f3d953ac05de3f7d68ddc327902d4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It cannot hurt to call
wb.close()
beforetm.assert_frame_equal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twoertwein, added.