BUG: setting dt64 values into Series[int] incorrectly casting dt64->int #39266
Conversation
jbrockmendel
commented
Jan 19, 2021
•
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jbrockmendel
added
the
Indexing
pandas/core/internals/blocks.py
Outdated
| if is_list_like(value): | ||
| value = list(value) | ||
| else: | ||
| value = [value] * len(values[indexer]) |
There was a problem hiding this comment.
same as above re numpy#12550
pandas/core/internals/blocks.py
Outdated
| # https://github.com/numpy/numpy/issues/12550 | ||
| # numpy will incorrect cast to int if we're not careful | ||
| if is_list_like(value): | ||
| value = list(value) |
There was a problem hiding this comment.
until numpy#12550 is fixed this is the only way i found to get this to work
pandas/core/internals/blocks.py
Outdated
| @@ -991,6 +991,18 @@ def setitem(self, indexer, value): | |||
|
|
|||
| # set | |||
| else: | |||
| if ( | |||
There was a problem hiding this comment.
no, we still want to fall through to L1006
There was a problem hiding this comment.
sure but i thin it is much more clear to use an elif and then simply repeat that line in the else
pandas/core/internals/blocks.py
Outdated
| @@ -991,6 +991,18 @@ def setitem(self, indexer, value): | |||
|
|
|||
| # set | |||
| else: | |||
| if ( | |||
There was a problem hiding this comment.
sure but i thin it is much more clear to use an elif and then simply repeat that line in the else
ok, will update. BTW #38709, #39044, #39163 also touch this code, will need to get those merged/rejected in order to move forward on the refactor in #39302. (and a very gentle ping on #38992 since I want to write more tests) |
|
rebased + green |
|
lgtm. can you merge master and ping on green |
…g-setitem-dt64-int
