Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: silently ignoring dtype kwarg in Index.__new__ #38879

Merged
merged 5 commits into from
Jan 1, 2021
Merged

BUG: silently ignoring dtype kwarg in Index.__new__ #38879

merged 5 commits into from
Jan 1, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 1, 2021 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

ATM we handle object but not others, xref #21311

@jreback jreback added Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses labels Jan 1, 2021
@jreback jreback added this to the 1.3 milestone Jan 1, 2021
@jreback
Copy link
Contributor

jreback commented Jan 1, 2021

nice cleanup. needs a rebase. should we consider deprecating dtype= keyword in the constructor?

@jbrockmendel
Copy link
Member Author

should we consider deprecating dtype= keyword in the constructor?

my hope/goal is for Index.__new__, Series.__init__, and pd.array` to share most of their code, so probably not

@jreback jreback merged commit 02166b7 into pandas-dev:master Jan 1, 2021
@jbrockmendel jbrockmendel deleted the ref-index-constructors branch January 2, 2021 01:37
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jbrockmendel @luckyvs1
BUG: silently ignoring dtype kwarg in Index.__new__ (pandas-dev#38879)
1203236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback