FIX hash of DataFrame raises Typerror #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -594,6 +594,9 @@ def axes(self): | |||
| def __repr__(self): | |||
| return 'NDFrame' | |||
|
|
|||
| def __hash__(self): | |||
| raise TypeError("unhashable type") | |||
There was a problem hiding this comment.
what about
def __hash__(self):
raise TypeError('{0!r} objects are mutable, thus they cannot be'
' hashed'.format(self.__class__.__name__))maybe for series too. i find that error message thoroughly unhelpful, which is so unlike pandas :)
There was a problem hiding this comment.
That's true, I just recklessly copied the error for numpy...
|
Currently this makes NDFrame not hashable. Changing the message for Series too with your improvement and adding tests :) |
|
All tests pass, so I guess we aren't hashing anything. There were know hashing tests in the docs before. Merge? |
|
ok by me |
hayd
added a commit
that referenced
this pull request
Jun 13, 2013
FIX hash of DataFrame raises Typerror
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3882
raise TypeError if trying to hash a DataFrame (or Panel etc.).