DEPR: allowing subclass-specific keywords in pd.Index.__new__ #38597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
reviewed
Dec 21, 2020
| @@ -506,7 +506,9 @@ def test_insert_index_period(self, insert, coerced_val, coerced_dtype): | |||
| else: | |||
| msg = r"Unexpected keyword arguments {'freq'}" | |||
| with pytest.raises(TypeError, match=msg): | |||
| pd.Index(data, freq="M") | |||
| with tm.assert_produces_warning(FutureWarning): | |||
| # passing keywords ot pd.Index | |||
jreback
requested changes
Dec 21, 2020
jreback
added
Constructors
topper-123
reviewed
Dec 22, 2020
jreback
approved these changes
Dec 22, 2020
|
can you merge master once more. i realized that the period keyword removal was merged before this |
|
somethings still failing in precommit |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff