Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement historical finance data from Google Finance #3814

Merged
merged 6 commits into from
Jun 10, 2013
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pandas/io/tests/test_google.py
Original file line number Diff line number Diff line change
@@ -12,7 +12,6 @@

class TestGoogle(unittest.TestCase):

@slow
@network
def test_google(self):
# asserts that google is minimally working and that it throws
@@ -39,13 +38,11 @@ def test_google(self):
raise


@slow
@network
def test_get_quote(self):
self.assertRaises(NotImplementedError,
lambda: web.get_quote_google(pd.Series(['GOOG', 'AAPL', 'GOOG'])))

@slow
@network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will these tests even run on travis on any python except 2.6? probably should just mark as network OR slow: if they use the network then network, otherwise slow if they are slow but not both since the tests exclude one or the other so if you both they won't be run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure @cpcloud I changed it to @network only.

def test_get_data(self):
import numpy as np