BUG: Fix inconsistent ordering between left and right in merge #37406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Oct 31, 2020
| @@ -2283,3 +2283,13 @@ def test_merge_join_categorical_multiindex(): | |||
| expected = expected.drop(["Cat", "Int"], axis=1) | |||
| result = a.join(b, on=["Cat1", "Int1"]) | |||
| tm.assert_frame_equal(expected, result) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("how", ["left", "right"]) | |||
There was a problem hiding this comment.
sort=True is ok? (do we test this)? can you locate this test function near similar tests.
There was a problem hiding this comment.
Sort True was the previous default behavior. Added tests to show behavior. Moved the tests up a bit right below a nosort test
|
can you merge master and will look |
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
merged master |
jreback
requested changes
Nov 19, 2020
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
Merged master too |
jreback
requested changes
Nov 20, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -712,6 +712,7 @@ Reshaping | |||
| - Fixed regression in :func:`merge` on merging DatetimeIndex with empty DataFrame (:issue:`36895`) | |||
| - Bug in :meth:`DataFrame.apply` not setting index of return value when ``func`` return type is ``dict`` (:issue:`37544`) | |||
| - Bug in :func:`concat` resulting in a ``ValueError`` when at least one of both inputs had a non-unique index (:issue:`36263`) | |||
| - Bug in :meth:`df.merge() <pandas.DataFrame.merge>` returning inconsistent ordering in result for ``how=right`` and ``how=left`` (:issue:`35382`) | |||
There was a problem hiding this comment.
you don't need to add the <...> instead do this like `:meth:`DataFrame.merge`
There was a problem hiding this comment.
also add :meth:`pandas.merge`
jreback
approved these changes
Nov 21, 2020
|
thanks @phofl very nice! |
|
Thx No they are not related. but #22449 can be closed probably, after we improved the Error Reporting here this should definitely fail as said by @TomAugspurger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffPassed sort through for right join too. Did not see a reason why not.
On a related note: I think outer joins return a inconsistent order too.
instead of
like
leftandrightnow. Would have to add asortkeyword to outer join. Should I open an issue for that?