TYP: mostly datetimelike #36696
Merged
TYP: mostly datetimelike #36696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Sep 29, 2020
| @@ -421,7 +427,7 @@ def is_full(self) -> bool: | |||
| """ | |||
| if len(self) == 0: | |||
| return True | |||
| if not self.is_monotonic: | |||
| if not self.is_monotonic_increasing: | |||
There was a problem hiding this comment.
Does this have any behavioral changes?
There was a problem hiding this comment.
No, just more explicit.
jreback
requested changes
Sep 30, 2020
pandas/core/indexes/datetimelike.py
Outdated
| @@ -157,6 +157,7 @@ def __contains__(self, key: Any) -> bool: | |||
| res = self.get_loc(key) | |||
| except (KeyError, TypeError, ValueError): | |||
| return False | |||
| return True | |||
There was a problem hiding this comment.
i think this and the FIXME weren't meant to be committed; will fix
There was a problem hiding this comment.
updated + all-but-arm-green
|
looks good, is this compat with what we merged in : #36742 maybe rebase just to be sure (and merge on green). |
jreback
approved these changes
Oct 1, 2020
|
Thanks @jbrockmendel |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff