Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix unintentionally added suffix in DataFrame.apply/agg and Series.apply/agg #36231

Merged
merged 17 commits into from
Sep 13, 2020

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Sep 8, 2020

@charlesdong1991 charlesdong1991 marked this pull request as draft September 8, 2020 21:28
@charlesdong1991 charlesdong1991 changed the title BUG: added suffix in DataFrame.apply and Series.apply BUG: Fixe unintentionally added suffix in DataFrame.apply/agg and Series.apply/agg Sep 9, 2020
@charlesdong1991 charlesdong1991 marked this pull request as ready for review September 9, 2020 17:46
@charlesdong1991 charlesdong1991 added Apply Apply, Aggregate, Transform, Map Bug Regression Functionality that used to work in a prior pandas version labels Sep 9, 2020
@charlesdong1991 charlesdong1991 added this to the 1.1.3 milestone Sep 9, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice @charlesdong1991 merge on green.

@simonjayhawkins
Copy link
Member

ci restarted

=========================== short test summary info ===========================
FAILED pandas/tests/plotting/test_groupby.py::TestDataFrameGroupByPlots::test_series_groupby_plotting_nominally_works
= 1 failed, 75150 passed, 1789 skipped, 1180 xfailed, 6 xpassed, 69 warnings in 1028.46s (0:17:08) =

@simonjayhawkins simonjayhawkins changed the title BUG: Fixe unintentionally added suffix in DataFrame.apply/agg and Series.apply/agg BUG: Fix unintentionally added suffix in DataFrame.apply/agg and Series.apply/agg Sep 13, 2020
@simonjayhawkins simonjayhawkins merged commit 752cd42 into pandas-dev:master Sep 13, 2020
@simonjayhawkins
Copy link
Member

Thanks @charlesdong1991

@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 13, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 752cd42ee5b5a3909c99de1ac35077d1446fce5b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #36231: BUG: Fix unintentionally added suffix in DataFrame.apply/agg and Series.apply/agg'
  1. Push to a named branch :
git push YOURFORK 1.1.x:auto-backport-of-pr-36231-on-1.1.x
  1. Create a PR against branch 1.1.x, I would have named this PR:

"Backport PR #36231 on branch 1.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Sep 13, 2020
simonjayhawkins added a commit that referenced this pull request Sep 13, 2020
…me.apply/agg and Series.apply/agg (#36340)

Co-authored-by: Kaiqi Dong <[email protected]>
@charlesdong1991 charlesdong1991 deleted the fix_36189 branch September 14, 2020 09:45
@charlesdong1991
Copy link
Member Author

thank you @simonjayhawkins for pushing this through yesterday! 🙇

=========================== short test summary info ===========================
FAILED pandas/tests/plotting/test_groupby.py::TestDataFrameGroupByPlots::test_series_groupby_plotting_nominally_works
= 1 failed, 75150 passed, 1789 skipped, 1180 xfailed, 6 xpassed, 69 warnings in 1028.46s (0:17:08) =

May I ask where was this failure popping up? is it something I should take a look for a potential issue? @simonjayhawkins

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Sep 14, 2020

not sure. I just add the test failure summary to increase visibility and help track. in this case has occurred b4 #36147 (comment)

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Bug Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Inconsistent behavior of index values for DataFrame.apply and Series.apply
3 participants