-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: vendor typing_extensions #36000
Conversation
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-09-01 16:25:26 UTC |
cc @WillAyd @simonjayhawkins thoughts on getting this to pass checks? |
FWIW I think OK to run the new module through isort / black; doesn't need to be a perfect reproduction AFAICT code check failures are mostly around internal style rules we place; OK to update to those as well as they are mostly cosmetic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbrockmendel
do we need any sort of testing for this?
setup.cfg
Outdated
@@ -29,6 +29,7 @@ exclude = | |||
doc/build/*.py, | |||
doc/temp/*.py, | |||
.eggs/*.py, | |||
pandas/_vendored/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still required to ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either way i guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove if not necessary; less things to ponder is always better
I wouldn't bother. FWIW not needing to worry about that is part of why i suggested making this a dependency in #34869 |
thanks @jbrockmendel |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
haven't figured out how to make isort and black ignore this file