BUG: Fix assert_equal when check_exact=True for non-numeric dtypes #3… #35522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
the
Testing
ivirshup
force-pushed
the
fix-assert_equal
branch
from
f28307e to
95b766c
Compare
|
@jreback, added the release note, and it's kinda green. It looks like one of the jobs timed out though. |
restarted |
jreback
requested changes
Aug 6, 2020
|
also pls merge master |
|
Made those changes. How is it now? |
jreback
approved these changes
Aug 10, 2020
|
thanks! |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 10, 2020
…True for non-numeric dtypes pandas-dev#3…
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 10, 2020
…on-numeric dtypes #3… (#35652) Co-authored-by: Isaac Virshup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_series_equal(..., check_exact=True)no longer raises an error when series has a non-numeric dtype. This fixes a bug/ regression introduced in1.1.0.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI've added a very simple test, but could add more. For instance, there could be a check on
assert_frame_equal, but I'm not sure what the desired strategy is for that.I've left off the
whatsnewentry for now since I figure that's the most likely to generate conflicts while this gets reviewed.