FIX: remove dependence on matplotlib.dates.epoch2num #35361
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
converter._dt_to_float_ordinal(dt)
special caseddatetime64
objects, and usedmatplotlib.dates.epoch2num
. However, matplotlib has supporteddatetime64
natively since Matplotlib 2.2 (matplotlib/matplotlib#9779), so this special casing shouldn't be necessary (unless there is a subtlety I'm missing). Matplotlib would also prefer to deprecateepoch2num
, so this would help us streamline.I didn't check your support policy - if you need to support pre MPL 2.2, then I guess some try/except logic will need to go in here.
ping @TomAugspurger @dstansby