Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPL dt conversion (epoch2num deprecation) #34850 #35333

Closed
wants to merge 1 commit into from
Closed

Fix MPL dt conversion (epoch2num deprecation) #34850 #35333

wants to merge 1 commit into from

Conversation

misantroop
Copy link

Fix datetime conversion after matplotlib (3.3.0 update) deprecating epoch2num.

Fix datetime conversion after matplotlib (3.3.0 update) deprecating epoch2num.
@TomAugspurger
Copy link
Contributor

Thanks @misantroop. Seems to be some test failures. Can you check?

____________________ TestDateTimeConverter.test_conversion _____________________
[gw2] darwin -- Python 3.6.10 /Users/runner/miniconda3/envs/pandas-dev/bin/python

self = <pandas.tests.plotting.test_converter.TestDateTimeConverter object at 0x161aaac18>

    def test_conversion(self):
        rs = self.dtc.convert(["2012-1-1"], None, None)[0]
        xp = datetime(2012, 1, 1).toordinal()
>       assert rs == xp
E       assert 15340.0 == 734503

pandas/tests/plotting/test_converter.py:150: AssertionError

Can you post images of the outputs with / without your changes for matplotlib 3.3 and an earlier version?

@igavronski
Copy link

Please see an alternative circumvent that takes into account the same problem here:
#34850 (comment)

@misantroop
Copy link
Author

misantroop commented Jul 22, 2020

Issue fixed in MPL: matplotlib/matplotlib#17983

@misantroop misantroop closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: epoch2num matplotlib deprecation warning
3 participants