TST: df.loc[:, 'col'] returning a view, but df.loc[df.index, 'col'] returning a copy #34996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this - are we expecting that this loc call copies? @mroeschke @jreback |
jreback
requested changes
Jun 25, 2020
pandas/tests/indexing/test_loc.py
Outdated
| @@ -346,6 +346,16 @@ def test_loc_index(self): | |||
| result = df.loc[pd.array(mask, dtype="boolean")] | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_loc_copy_vs_view(self): | |||
There was a problem hiding this comment.
hmm I am almost sure we have other tests about this, can you check and co-locate
There was a problem hiding this comment.
Yes you're right. This one
pandas/pandas/tests/indexing/test_loc.py
Line 872 in f5b2e5a
is very similar so moved it there
|
@arw2019 are you still working on this? |
|
@erfannariman yes I think this is ready to go, waiting for review |
jreback
added
Indexing
yes this has been the case for a long time |
jreback
approved these changes
Jun 30, 2020
jreback
requested changes
Jun 30, 2020
jreback
approved these changes
Jul 9, 2020
|
thanks @arw2019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff