-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: groupby apply with indexing and column aggregation returns the column #7002 #34647
TST: groupby apply with indexing and column aggregation returns the column #7002 #34647
Conversation
Hello @VirosaLi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-09 06:10:16 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VirosaLi generally lgtm. a couple of unrelated changes crept in. can you revert those.
@VirosaLi can you address @simonjayhawkins comments? Lgtm otherwise |
@VirosaLi Thanks for the updates. lgtm. ping on green |
One of the checks is on pending for hours. Is this normal? |
Travis is glitchy sometimes, it's green if you click through |
thanks @VirosaLi |
Adds test for #7002
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff