Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: groupby apply with indexing and column aggregation returns the column #7002 #34647

Merged
merged 12 commits into from
Jun 14, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jun 8, 2020

Adds test for #7002

@pep8speaks
Copy link

pep8speaks commented Jun 8, 2020

Hello @VirosaLi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-09 06:10:16 UTC

pandas/tests/groupby/test_apply.py Outdated Show resolved Hide resolved
pandas/tests/groupby/test_apply.py Outdated Show resolved Hide resolved
@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels Jun 8, 2020
@jreback jreback added this to the 1.1 milestone Jun 8, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VirosaLi generally lgtm. a couple of unrelated changes crept in. can you revert those.

pandas/tests/groupby/test_apply.py Outdated Show resolved Hide resolved
pandas/tests/groupby/test_apply.py Outdated Show resolved Hide resolved
@fangchenli fangchenli requested a review from dsaxton June 10, 2020 15:11
@WillAyd
Copy link
Member

WillAyd commented Jun 13, 2020

@VirosaLi can you address @simonjayhawkins comments? Lgtm otherwise

@simonjayhawkins
Copy link
Member

@VirosaLi Thanks for the updates. lgtm. ping on green

@fangchenli
Copy link
Member Author

One of the checks is on pending for hours. Is this normal?

@dsaxton
Copy link
Member

dsaxton commented Jun 14, 2020

One of the checks is on pending for hours. Is this normal?

Travis is glitchy sometimes, it's green if you click through

@jreback jreback merged commit 9dca069 into pandas-dev:master Jun 14, 2020
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

thanks @VirosaLi

@fangchenli fangchenli deleted the test-groupby-apply-indexing branch June 15, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG/TST: verify that groupby apply with a column aggregation does not return the column
6 participants