CLN: Removed duplicated test data #34477
Conversation
|
Hey @alimcmaster1 Is part of this already addressed in #34458? |
Morning, thanks for pointing this out. I think we will just want to remove pandas/tests/data in that PR? Whereas here I was looking at io/parser/data and io/data directories here |
alimcmaster1
changed the title
alimcmaster1
added
the
Testing
alimcmaster1
changed the title
|
@WillAyd you able to review this? Thanks! |
| @@ -53,11 +53,11 @@ def csv_dir_path(datapath): | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def csv1(csv_dir_path): | |||
There was a problem hiding this comment.
What's the reason for doing this instead of editing csv_dir_path?
There was a problem hiding this comment.
csv_dir_path is used across quite a few tests. We would have to move all csvs from io/parser/data to io/data/csv if we wanted to do this.
There was a problem hiding this comment.
Gotcha. I think makes sense to do that but can be done as a follow up
|
thanks @alimcmaster1 very nice |
Remove duplicated test data.
"test1.csv" & "tips.csv" are present in both "tests/io/parser/data" & "tests/io/data/csv".
Move the ".csv.bz2" & ".csv.gz" files since the s3_resource fixture in tests/io/conftest requires these.
Follow up from: #29439
Think we should move all the data in io/parser/data/* into io/data/ so it can be re-used. Will save for follow up.