Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix EX02 and SA01 in DataFrame.select_dtypes #34362

Merged
merged 1 commit into from
May 27, 2020

Conversation

farhanreynaldo
Copy link
Contributor

@farhanreynaldo farhanreynaldo commented May 25, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Related to #27977.

output of python scripts/validate_docstrings.py pandas.DataFrame.select_dtypes:

################################################################################
################################## Validation ##################################
################################################################################

1 Errors found:
        No extended summary found

Notes:
It seems like passing int to the parameter do not include/exclude all integer dtypes. But, passing integer would do otherwise. I think it is related to this issue #29394. It would be more convenient if passing int as an input would match the result with passing integer.

@jreback jreback added the Docs label May 25, 2020
@WillAyd WillAyd added this to the 1.1 milestone May 27, 2020
@WillAyd WillAyd merged commit 707640c into pandas-dev:master May 27, 2020
@WillAyd
Copy link
Member

WillAyd commented May 27, 2020

Great thanks @farhanreynaldo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants