Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check private function not used across modules #33393

Conversation

ShaharNaveh
Copy link
Member

@pep8speaks
Copy link

Hello @MomIsBestFriend! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 154:9: E266 too many leading '#' for block comment

@ShaharNaveh ShaharNaveh closed this Apr 8, 2020
@ShaharNaveh ShaharNaveh deleted the CI-PrivateFunctionAcrossModules branch April 8, 2020 13:03
@jbrockmendel
Copy link
Member

@MomIsBestFriend can i convince you to pick this and/or #33394 back up? I found myself manually tracking down incorrectly-private functions today, would be nice to avoid that need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants