CLN: Static types in pandas/_lib/lib.pyx
#33329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Apr 6, 2020
pandas/_libs/lib.pyx
Outdated
| @@ -103,12 +103,10 @@ def memory_usage_of_objects(arr: object[:]) -> int64_t: | |||
|
|
|||
| Does not include the actual bytes of the pointers | |||
| """ | |||
| i: Py_ssize_t | |||
| n: Py_ssize_t | |||
| size: int64_t | |||
There was a problem hiding this comment.
we put this in because it is consistent with pure-python syntax
jbrockmendel
reviewed
Apr 6, 2020
pandas/_libs/lib.pyx
Outdated
| 'interval': 'interval', | ||
| } | ||
| cdef: | ||
| dict _TYPE_MAP = { |
There was a problem hiding this comment.
do we actually get anything from typing this?
one of the pie-in-the-sky goals is to get the cython code close enough to valid python that we can make flake8 work on it; this is going in the other direction
There was a problem hiding this comment.
do we actually get anything from typing this?
I looked at the generated C code, and it looks like we don't gain anything from typing this, I assumed we did, but I guess not.
|
Thanks @MomIsBestFriend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff