Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to include/ignore file extensions in scripts/validate_unwanted/patterns.py #33216

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This is needed for the check in #32942 to ignore cython files.

@ShaharNaveh ShaharNaveh force-pushed the CI-UnHardCodeFilesToCheck-scripts-validate_unwanted_patterns branch 2 times, most recently from 84d88f1 to f916fe6 Compare April 1, 2020 20:05
MomIsBestFriend added 3 commits April 1, 2020 23:06
in `scripts/validate_unwanted_patterns.py`
…sToCheck-scripts-validate_unwanted_patterns
…sToCheck-scripts-validate_unwanted_patterns
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Apr 10, 2020
@jreback jreback added this to the 1.1 milestone Apr 10, 2020
@jreback jreback merged commit 48838da into pandas-dev:master Apr 10, 2020
@jreback
Copy link
Contributor

jreback commented Apr 10, 2020

sure

@ShaharNaveh ShaharNaveh deleted the CI-UnHardCodeFilesToCheck-scripts-validate_unwanted_patterns branch April 11, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants