CLN: Added static types #33169
Merged
CLN: Added static types #33169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 31, 2020
pandas/_libs/tslibs/parsing.pyx
Outdated
| object default, | ||
| bint ignoretz=False, | ||
| tzinfos=None, | ||
| dayfirst=None, |
There was a problem hiding this comment.
Doing so will require changing the default value of dayfirst, is it okay?
pandas/_libs/tslibs/parsing.pyx
Outdated
| str timestr, | ||
| object default, | ||
| bint ignoretz=False, | ||
| tzinfos=None, |
|
lgtm |
added 5 commits
April 1, 2020 12:31
…libs-tslibs-parsing
…libs-tslibs-parsing
…libs-tslibs-parsing
|
@jreback any outstanding comments? |
|
thanks @MomIsBestFriend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI'll revert any change related to styling, I applied "black" formatting in some places, just so I could think straight.