-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: add test for get_loc on tz-aware DatetimeIndex #32152
TST: add test for get_loc on tz-aware DatetimeIndex #32152
Conversation
key = pd.Timestamp("2019-12-12 10:19:25", tz="US/Eastern") | ||
result = dti.get_loc(key, method="nearest") | ||
assert result == 7433 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (not a blocker), can you put this a few tests up adjacent to the other tests that use the method
kwarg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
LGTM |
thanks @simonjayhawkins |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
@simonjayhawkins may need a manual backport |
…oc on tz-aware DatetimeIndex)
…ware DatetimeIndex) (#32160)
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff