Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Backport PR #31679 on branch 1.0.x" #32088

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 19, 2020

@jbrockmendel jbrockmendel added this to the 1.0.2 milestone Feb 19, 2020
@@ -17,6 +17,9 @@ Fixed regressions

- Fixed regression in :meth:`DataFrame.to_excel` when ``columns`` kwarg is passed (:issue:`31677`)
- Fixed regression in :meth:`Series.align` when ``other`` is a DataFrame and ``method`` is not None (:issue:`31785`)
- Fixed regression in :meth:`pandas.core.groupby.RollingGroupby.apply` where the ``raw`` parameter was ignored (:issue:`31754`)
- Fixed regression in :meth:`rolling(..).corr() <pandas.core.window.Rolling.corr>` when using a time offset (:issue:`31789`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some "merge conflicts" here, those are from other PRs (that were not backported yet .. we should more diligently follow up with backports to avoid this)

@simonjayhawkins
Copy link
Member

@jorisvandenbossche OK to merge?

@jorisvandenbossche
Copy link
Member

Yes, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 99c14ed into pandas-dev:1.0.x Feb 19, 2020
@jbrockmendel jbrockmendel deleted the auto-backport-of-pr-31679-on-1.0.x branch February 19, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants