Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix to_excel writers handling of cols #31729

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Feb 6, 2020

Ref: #31723

cc. @WillAyd @jbrockmendel

@pep8speaks
Copy link

pep8speaks commented Feb 6, 2020

Hello @alimcmaster1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-06 21:26:42 UTC

@alimcmaster1 alimcmaster1 added IO Excel read_excel, to_excel Bug Regression Functionality that used to work in a prior pandas version labels Feb 6, 2020
@alimcmaster1 alimcmaster1 added this to the 1.0.2 milestone Feb 6, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbrockmendel
Copy link
Member

lgtm

@WillAyd
Copy link
Member

WillAyd commented Feb 6, 2020

Can you add a whatsnew for 1.0.2?

@jreback jreback merged commit d0c84ce into pandas-dev:master Feb 6, 2020
@jreback
Copy link
Contributor

jreback commented Feb 6, 2020

thanks @alimcmaster1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas excel output specify column names to write is broken in 1.0.0
6 participants