Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: more informative error message when trying to cythonize with old cython version #30774

Merged
merged 1 commit into from
Jan 7, 2020
Merged

BLD: more informative error message when trying to cythonize with old cython version #30774

merged 1 commit into from
Jan 7, 2020

Conversation

jorisvandenbossche
Copy link
Member

cc @jbrockmendel building upon your #30498, but making the error message more specific when cython is actually installed but too old.

@jorisvandenbossche jorisvandenbossche added the Build Library building on various platforms label Jan 7, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Jan 7, 2020
datapythonista
datapythonista approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@TomAugspurger TomAugspurger merged commit b5da1ae into pandas-dev:master Jan 7, 2020
@jorisvandenbossche jorisvandenbossche deleted the setup-cython-error branch January 7, 2020 12:02
@jbrockmendel
Copy link
Member

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jorisvandenbossche @jbrockmendel @datapythonista @simonjayhawkins @TomAugspurger