BUG: Expand encoding for C engine beyond utf-16 #30771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
utf-xx-encodings-csv
branch
3 times, most recently
from
60ca4e3 to
74ab9cd
Compare
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| from io import BytesIO | |||
| import os | |||
| import tempfile | |||
There was a problem hiding this comment.
can pytest builtin fixture or ensure_clean be used instead?
There was a problem hiding this comment.
I need the encoding to be parameterized in this test, which can't be done with ensure_clean at the moment (though could be a useful enhancement as a follow-up).
The pytest builtin fixture has a similar issue (as an aside, if I had to choose between ensure_clean or pytest fixture, I would generally go with our in-house one since it's a little more flexible to use).
And by utf-16, we mean the string "utf-16" Closes pandas-dev#24130
gfyoung
force-pushed
the
utf-xx-encodings-csv
branch
from
74ab9cd to
2a62025
Compare
|
thanks @gfyoung very nice |
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Jan 11, 2020
These keywords will be passed through to tempfile constructor functions. Follow-up: pandas-dev#30771
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Jan 11, 2020
These keywords will be passed through to tempfile constructor functions. Follow-up: pandas-dev#30771
jreback
pushed a commit
that referenced
this pull request
Jan 15, 2020
These keywords will be passed through to tempfile constructor functions. Follow-up: #30771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And by
utf-16, we mean the string"utf-16"Closes #24130