REF: separate casting out of Index.__new__ #30586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 31, 2019
jreback
reviewed
Jan 1, 2020
| try: | ||
| res = data.astype("i8", copy=False) | ||
| if (res == data).all(): | ||
| return res # TODO: might still need to copy |
There was a problem hiding this comment.
should be in pandas/core/dtypes/cast.py and i think duplicates some code there, but ok for now.
jreback
requested changes
Jan 1, 2020
jreback
added
Dtype Conversions
jreback
approved these changes
Jan 1, 2020
|
thanks |
hweecat
pushed a commit
to hweecat/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first of two PRs to separate array casting/inference out of
Index.__new__. Once both are in place, we'll be able to do all inference/casting up-front and simplify the constructor quite a bit. We'll also be able to look into sharing code between Index/Series/array, and address a handful of outstanding issues with the Index constructor.