Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Clean test moments for expanding #30566

Merged
merged 5 commits into from
Jan 1, 2020

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Dec 30, 2019

@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Dec 30, 2019

Hello, @jreback and @mroeschke

This is the first follow-up PR for #30542 , and I plan to clean it in three steps in order to keep PR small and readable:

  1. this PR will focus on expanding
  2. the second PR will focus on ewm
  3. the last PR will focus on _test_moments_consistency which is in common.py and this will probably influence all three files since they all inherit from this (expanding, ewm and rolling)

If you have any other suggestions on how to proceed, feel free to bring up!

@jreback jreback added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Jan 1, 2020
@jreback jreback added this to the 1.0 milestone Jan 1, 2020
@jreback jreback merged commit 7ecd9af into pandas-dev:master Jan 1, 2020
@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

thanks @charlesdong1991 this is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants