Performance of maybe_box_datetimelike #30520 #30531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ivan-vasilev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-01 23:40:02 UTC |
jreback
requested changes
Dec 28, 2019
pandas/core/common.py
Outdated
| @@ -84,9 +84,11 @@ def maybe_box(indexer, values, obj, key): | |||
| def maybe_box_datetimelike(value): | |||
| # turn a datetime like into a Timestamp/timedelta as needed | |||
|
|
|||
| if isinstance(value, (np.datetime64, datetime)): | |||
| if isinstance(value, (np.datetime64, datetime)) \ | |||
| and not isinstance(value, tslibs.Timestamp): | |||
|
See my comment in the issue: #30520 (comment). Is this really the appropriate place for the performance fix? Or should this be done in the |
simonjayhawkins
changed the title
jschendel
reviewed
Dec 29, 2019
|
linting issue should be fixable by running |
jreback
requested changes
Jan 1, 2020
| @@ -121,4 +122,13 @@ def time_convert(self, data): | |||
| lib.maybe_convert_numeric(data, set(), coerce_numeric=False) | |||
|
|
|||
|
|
|||
| from .pandas_vb_common import setup # noqa: F401 isort:skip | |||
pandas/core/common.py
Outdated
| and obj.stop is None | ||
| and obj.step is None | ||
| isinstance(obj, slice) | ||
| and obj.start is None |
There was a problem hiding this comment.
can you avoid other whitespace changes
|
this is subsumed by #30676 (though if you still think there is a perf benefit after that certainly ping). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffmaybe_box_datetimelikeavoids unnecessary conversion ofvaluetotslibs.Timestamportslibs.Timedeltaifvalueis already an instance oftslibs.Timestamportslibs.Timedelta.