BUG: hash_pandas_object fails on array containing tuple #28969 #30508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Dec 27, 2019
pandas/core/util/hashing.py
Outdated
| except ValueError: | ||
| # GH#28969 if we contain tuples, astype fails here, | ||
| # apparently related to github.com/numpy/numpy/issues/9441 | ||
| str_vals = np.array([str(x) for x in vals], dtype=object) |
There was a problem hiding this comment.
Hmm not sure about this - wouldn't this really make everything hashable at this point, including non-hashable items?
>>> vals = np.array([("a",), ["c", "d"]])
>>> str_vals = np.array([str(x) for x in vals], dtype=object)
array(["('a',)", "['c', 'd']"], dtype=object)
jreback
requested changes
Dec 27, 2019
pandas/core/util/hashing.py
Outdated
| @@ -306,8 +307,15 @@ def hash_array( | |||
| vals = hashing.hash_object_array(vals, hash_key, encoding) | |||
| except TypeError: | |||
| # we have mixed types | |||
| try: | |||
| str_vals = vals.astype(str) | |||
There was a problem hiding this comment.
i would handle this in hash_object_array as a case
|
moved the tuple-catching to hash_object_array, added check for non-hashable within a tuple |
jreback
requested changes
Dec 30, 2019
|
also have 2 tests in the OP |
|
Also needs a whatsnew note. |
these are the df1 and df2 in the test that this adds.
updated. |
TomAugspurger
approved these changes
Dec 31, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffATM this implements a smoke-test that the cases don't raise, but I don't have a canonical answer to test them against. Could hard-code the result I get now. Thoughts?