-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fixed strange behaviour of pd.DataFrame.drop() with inplace argu… #30501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are removing quite a lot of code here, this is likely not the soln. you need to trace thru the function calls.
The code that you removed is used in many different files. If you check the Travis CI logs you will see a list of failures. Below are a few places where those methods are used: pandas/tests/frame/test_operators.py You will probably need to either change the current implementation or reimplement those methods elsewhere. |
Thank you guys! I've run some tests before the PR, so it turns out I was running the wrong ones. I'll take another look and try to find a better solution. |
I've now fixed the problem by adding a new argument to NDFrame._maybe_update_cacher. All the test are running fine, but the pipeline fails in building the documentation: Is this related to something I've done? Can you provide some guidance on how to solve this? |
Looking further in the azure logs I see that the build is failing because of the following file: doc/source/user_guide/enhancingperf.rst I would look through that file and see if anything that you changed is referenced there. |
Thanks for the remarks and for the review. I'll get back to it as soon as I have time |
HI @rjfs - sorry to chase you up, just wanted to ask whether you're still working on this :) |
Hi @MarcoGorelli, no problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems should be solved in the new commit. Thanks for the review
looks good. can you add a note in 1.1, reshaping bug fixes. ping on green. |
It's done, thanks! |
@rjfs can you rebase once again, azure pipelines are not triggering fro some reason; I think its fixed. |
still not triggering it seems... |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
lgtm. let's merge on green. |
pls merge master and a lint issue:
ping on green. |
ping @jreback |
thanks @rjfs |
closes #30484
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
This is my first PR, so pardon me if I did something wrong.
To fix this issue I started by creating a failing test based on the example given by the reporter. After, I fixed the test by removing the "inplace" special methods from add_special_arithmetic_methods, following what was suggested as a comment in the code.