Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots #30288 #30491

Merged
merged 6 commits into from
Dec 27, 2019
Merged

BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots #30288 #30491

merged 6 commits into from
Dec 27, 2019

Conversation

souvik3333
Copy link
Contributor

jreback
jreback requested changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note (plotting bugs)

pandas/tests/plotting/test_hist_method.py Show resolved Hide resolved
@jreback jreback added this to the 1.0 milestone Dec 27, 2019
jreback
jreback requested changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. pls add a whatsnew note in plotting bugfixes for 1.0.0, ping on green.

@souvik3333
Copy link
Contributor Author

@jreback, I have updated the whatsnew entry.

@jreback jreback merged commit 0a3c1d7 into pandas-dev:master Dec 27, 2019
@jreback
Copy link
Contributor

jreback commented Dec 27, 2019

great thanks @souvik3333

@souvik3333 souvik3333 deleted the dataframe-hist-xrot-fix branch December 27, 2019 16:34
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@souvik3333 @AlexKirko
BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and …
b195dd6 
…subplots pandas-dev#30288 (pandas-dev#30491)
keechongtan added a commit to keechongtan/pandas that referenced this pull request Dec 29, 2019
@keechongtan
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
c5a7f6e 
…ndexing-1row-df

* upstream/master: (333 commits)
  CI: troubleshoot Web_and_Docs failing (pandas-dev#30534)
  WARN: Ignore NumbaPerformanceWarning in test suite (pandas-dev#30525)
  DEPR: camelCase in offsets, get_offset (pandas-dev#30340)
  PERF: implement scalar ops blockwise (pandas-dev#29853)
  DEPR: Remove Series.compress (pandas-dev#30514)
  ENH: Add numba engine for rolling apply (pandas-dev#30151)
  [ENH] Add to_markdown method (pandas-dev#30350)
  DEPR: Deprecate pandas.np module (pandas-dev#30386)
  ENH: Add ignore_index for df.drop_duplicates (pandas-dev#30405)
  BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots pandas-dev#30288 (pandas-dev#30491)
  CI: Fix GBQ Tests (pandas-dev#30478)
  Bug groupby quantile listlike q and int columns (pandas-dev#30485)
  ENH: Add ignore_index for df.sort_values and series.sort_values (pandas-dev#30402)
  TYP: Typing hints in pandas/io/formats/{css,csvs}.py (pandas-dev#30398)
  BUG: raise on non-hashable Index name, closes pandas-dev#29069 (pandas-dev#30335)
  Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502)
  BUG: preserve EA dtype in transpose (pandas-dev#30091)
  BLD: add check to prevent tempita name error, clsoes pandas-dev#28836 (pandas-dev#30498)
  REF/TST: method-specific files for test_append (pandas-dev#30503)
  marked unused parameters (pandas-dev#30504)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Visualization plotting
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots
2 participants
@souvik3333 @jreback