TST/REF: fixturize so as to avoid 500+ skips #30456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Dec 24, 2019
| ), | ||
| pytest.param("odf", marks=td.skip_if_no("odf")), | ||
| ] | ||
| _transfer_marks(eng, ext) |
There was a problem hiding this comment.
Would it alternately be possible to just change the scope of this fixture to be class level? This is a decent amount of logic to sift through for parametrization just wondering if we can't strike a better balance with a scope="class" argument rather than all of this logic
There was a problem hiding this comment.
I couldn't find a way to do what you're describing, but agree it would be nice.
5 tasks
|
thanks, happy to remove these skips! |
13 tasks
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-order the fixturizatin of engine and read_ext so as to yield only valid combinations, avoiding the need to pytest.skip the invalid combinations. This cuts out 500+ pytest.skips, which is about a third of the skips I see when i test with
--not-slow.The idea is that by cutting down on skips we can keep a closer eye on them, and things like this wont fall through the cracks quite as easily.