Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Fix abc imports #30455

Merged
merged 1 commit into from
Dec 24, 2019
Merged

CLN: Fix abc imports #30455

merged 1 commit into from
Dec 24, 2019

Conversation

alimcmaster1
Copy link
Member

invgrep/Github actions exit status doesn't seem to be working correctly.

Currently on master we get these errors in the code_checks stage:
https://github.com/pandas-dev/pandas/pull/30452/checks#step:4:7

As per discussion here:
#30370 (comment)

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on green

If you have interest in dissecting invgrep later would also be welcome

@WillAyd WillAyd added CI Continuous Integration Clean labels Dec 24, 2019
@WillAyd WillAyd added this to the 1.0 milestone Dec 24, 2019
@alimcmaster1 alimcmaster1 changed the title CLN: Fix abc imports WIP: CLN: Fix abc imports Dec 24, 2019
@alimcmaster1
Copy link
Member Author

lgtm ping on green

If you have interest in dissecting invgrep later would also be welcome

Aha I think i've found the cause - see #30457

@alimcmaster1 alimcmaster1 changed the title WIP: CLN: Fix abc imports CLN: Fix abc imports Dec 24, 2019
@alimcmaster1
Copy link
Member Author

Code checks now runs without error for non standard imports

Run ci/code_checks.sh patterns
Check for non-standard imports
Check for non-standard imports DONE

green cc. @WillAyd

@mroeschke mroeschke merged commit 8e0bec4 into pandas-dev:master Dec 24, 2019
@mroeschke
Copy link
Member

Thanks for the quick turnaround @alimcmaster1!

@alimcmaster1 alimcmaster1 deleted the mcmali-code-checks branch December 25, 2019 20:27
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants