CLN/TYP: Removed redundant 'int' from pandas/_typing.py #30426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
changed the title
jreback
reviewed
Dec 23, 2019
| @@ -32,7 +32,7 @@ | |||
| FilePathOrBuffer = Union[str, Path, IO[AnyStr]] | |||
|
|
|||
| FrameOrSeries = TypeVar("FrameOrSeries", bound="NDFrame") | |||
| Scalar = Union[str, int, float, bool] | |||
There was a problem hiding this comment.
how is this redundant? try an int is a float, but so it a bool technically, we want to be very explicit on these types.
|
Whether or not this changes anything for the type checker I think should keep both for the sake of explicitness |
|
closing as per comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAs @simonjayhawkins says here (comment), having
Unionwith bothintandfloatis redundant.