Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add ignore_index for df.drop_duplicates #30405

Merged
merged 15 commits into from
Dec 27, 2019
Merged

ENH: Add ignore_index for df.drop_duplicates #30405

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
3faf5cc
Merge remote-tracking branch 'upstream/master' into fix_issue_30114_d…
charlesdong1991 Dec 22, 2019
bdda8ca
Add ignore_index for drop duplicates
charlesdong1991 Dec 22, 2019
6e76e56
add forgotten test and code change based on review
charlesdong1991 Dec 22, 2019
c12beb6
code change on WA review
charlesdong1991 Dec 23, 2019
1b6dc51
keep consistency
charlesdong1991 Dec 23, 2019
17dbcb0
code change based on JR review
charlesdong1991 Dec 24, 2019
a173eea
add test
charlesdong1991 Dec 24, 2019
4a37e8f
restore wrong deleted code
charlesdong1991 Dec 24, 2019
79a49e1
remove
charlesdong1991 Dec 24, 2019
5fb6e54
Merge remote-tracking branch 'upstream/master' into fix_issue_30114_d…
charlesdong1991 Dec 26, 2019
a8552d8
code change based on JR review
charlesdong1991 Dec 26, 2019
6eaff2e
simplify code
charlesdong1991 Dec 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ Other API changes
Supplying anything else than ``how`` to ``**kwargs`` raised a ``TypeError`` previously (:issue:`29388`)
- When testing pandas, the new minimum required version of pytest is 5.0.1 (:issue:`29664`)
- :meth:`Series.str.__iter__` was deprecated and will be removed in future releases (:issue:`28277`).

- Add ``ignore_index`` to :meth:`DataFrame.drop_duplicates` to reset index (:issue:`30114`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverse the ordering here, e.g. .drop_duplicates has gained the ignore_index keyword.

move to other enhancements

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved and rephrased!


.. _whatsnew_1000.api.documentation:

Expand Down
8 changes: 8 additions & 0 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4587,6 +4587,7 @@ def drop_duplicates(
subset: Optional[Union[Hashable, Sequence[Hashable]]] = None,
keep: Union[str, bool] = "first",
inplace: bool = False,
ignore_index: bool = False,
) -> Optional["DataFrame"]:
"""
Return DataFrame with duplicate rows removed.
Expand All @@ -4606,6 +4607,8 @@ def drop_duplicates(
- False : Drop all duplicates.
inplace : bool, default False
Whether to drop duplicates in place or to return a copy.
ignore_index : bool, default False
If True, the resulting axis will be labeled 0, …, n - 1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If True, the resulting axis will be labeled 0, …, n - 1.
If True, the resulting axis will be labeled 0, 1, …, n - 1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, changed!


Returns
-------
Expand All @@ -4621,8 +4624,13 @@ def drop_duplicates(
if inplace:
(inds,) = (-duplicated)._ndarray_values.nonzero()
new_data = self._data.take(inds)
if ignore_index:
jreback marked this conversation as resolved.
Show resolved Hide resolved
new_data.axes[1] = ibase.default_index(len(inds))
jreback marked this conversation as resolved.
Show resolved Hide resolved
jreback marked this conversation as resolved.
Show resolved Hide resolved
self._update_inplace(new_data)
else:
if ignore_index:
idx = ibase.default_index(len(self[-duplicated]))
Copy link
Member

@WillAyd WillAyd Dec 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this block could be more succinctly written as:

result = self[~duplicated]
if ignore_index:
    result = result.reset_index(drop=True)

return result

Or something similar. FWIW I think the current method of evaluating self[~duplicated] twice can be costly for larger frames

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, good call! @WillAyd

will change! i think idx = ibase.default_index(sum(-duplicated)) should be also faster than using self[-duplicated]

return self[-duplicated].set_index(idx)
return self[-duplicated]

return None
Expand Down