Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: wrap ExcelFile.__del__ in try/except #30255

Merged
merged 1 commit into from
Dec 13, 2019
Merged

CI: wrap ExcelFile.__del__ in try/except #30255

merged 1 commit into from
Dec 13, 2019

Conversation

jorisvandenbossche
Copy link
Member

Closes #30217

@jorisvandenbossche
Copy link
Member Author

cc @jbrockmendel @WillAyd

@jreback jreback added the CI Continuous Integration label Dec 13, 2019
@WillAyd WillAyd added this to the 1.0 milestone Dec 13, 2019
WillAyd
WillAyd approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I suppose if this hits an AttributeError things are just leaked right?

@jbrockmendel
Copy link
Member

Worth a shot

@WillAyd WillAyd merged commit 1083472 into pandas-dev:master Dec 13, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 13, 2019

Thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the ci-excel-del branch December 14, 2019 07:45
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jorisvandenbossche @proost
CI: wrap ExcelFile.__del__ in try/except (pandas-dev#30255)
f8a2769
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jorisvandenbossche @proost
CI: wrap ExcelFile.__del__ in try/except (pandas-dev#30255)
b5a663e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

CI Error AttributeError: 'ExcelFile' object has no attribute 'engine'
4 participants
@jorisvandenbossche @jbrockmendel @WillAyd @jreback