Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: changed .format to f string in construction.py, dtypes/base.py, and dtypes/cast.py #30223

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

katieyounglove
Copy link
Contributor

  • ref #29547
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@gfyoung gfyoung added Strings String extension data type and string data Code Style Code style, linting, code_checks labels Dec 12, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

And welcome to pandas !

@jreback
Copy link
Contributor

jreback commented Dec 12, 2019

thanks @katieyounglove

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants