Replaced !r with repr() #30020
Merged
Replaced !r with repr() #30020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvn219
changed the title
|
Thanks for the PR. Looks good and I think CI failures are unrelated / have been fixed on master since this was created. To be sure, can you locally on your git fetch upstream
git merge upstream/master
git push origin fstring-sortingI think should get CI green for this. Flag me down at PyData if you have any questions |
simonjayhawkins
approved these changes
Dec 4, 2019
jreback
reviewed
Dec 4, 2019
pandas/core/sorting.py
Outdated
| @@ -264,7 +264,7 @@ def nargsort(items, kind="quicksort", ascending: bool = True, na_position="last" | |||
| elif na_position == "first": | |||
| indexer = np.concatenate([nan_idx, indexer]) | |||
| else: | |||
| raise ValueError("invalid na_position: {!r}".format(na_position)) | |||
| raise ValueError(f"invalid na_position: {repr(na_position)}") | |||
There was a problem hiding this comment.
you can remove the repr on both of these as its unecessary
There was a problem hiding this comment.
Thanks for the feedback @jreback, I just pushed with repr() removed.
|
Looks like a merge conflict @kvn219 can you fix that up and re-push? |
|
|
Hey @WillAyd, I'm not sure what to do. I'll go to HackLA next week and ask for help. |
|
Thanks @kvn219 |
This was referenced Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIssue: #29886
@WillAyd