CI: added unwanted pattern test case for "foo.__class__" instead of type(foo) #29937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
changed the title
ShaharNaveh
changed the title
jbrockmendel
added
CI
|
Looks good. To be sure can you intentionally change the code somewhere to make this fail so we can see how it looks in CI? |
|
ping @WillAyd |
|
This is how it looks in CI. Might be worth adding something that explains one should use type()? |
WillAyd
approved these changes
Dec 1, 2019
|
Great thanks @MomIsBestFriend |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffref #29816 (splitted to #29889, #29893, #29894, #29902, #29904, #29905)