Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: follow-up to 29725 #29890

Merged
merged 1 commit into from
Nov 27, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CLN: follow-up to 29725
jbrockmendel committed Nov 27, 2019
commit a07bc50bfa8010527de63b74e8b9e8ee332404ee
2 changes: 1 addition & 1 deletion pandas/conftest.py
Original file line number Diff line number Diff line change
@@ -878,6 +878,6 @@ def index_or_series(request):

List item 0 has incompatible type "Type[Series]"; expected "Type[PandasObject]"

See GH#?????
See GH#29725
"""
return request.param
2 changes: 1 addition & 1 deletion pandas/tests/arithmetic/test_numeric.py
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ def adjust_negative_zero(zero, expected):

# TODO: remove this kludge once mypy stops giving false positives here
# List comprehension has incompatible type List[PandasObject]; expected List[RangeIndex]
# See GH#?????
# See GH#29725
ser_or_index: List[Any] = [pd.Series, pd.Index]
lefts: List[Any] = [pd.RangeIndex(10, 40, 10)]
lefts.extend(
2 changes: 1 addition & 1 deletion pandas/tests/test_strings.py
Original file line number Diff line number Diff line change
@@ -666,7 +666,7 @@ def test_str_cat_align_mixed_inputs(self, join):

index_or_series2 = [Series, Index] # type: ignore
# List item 0 has incompatible type "Type[Series]"; expected "Type[PandasObject]"
# See GH#>????
# See GH#29725

@pytest.mark.parametrize("other", index_or_series2)
def test_str_cat_all_na(self, index_or_series, other):