Changed string formatting to fstring

[ForTimeBeing]

• xref Replace old string formatting syntax with f-strings #29547
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

I am new to contributing to open source projects bare with me. I normally only push to my own
master branch. I have never used git diff before(I know it is supposed to compare changed) and I just keep getting the error: fatal: bad revision 'upstream/master' if someone could tell me how to properly use it that would be great! It passed the black pandas test though. Once I figure out how to properly submit a PR abiding by pandas standards I will do trying a lot more PR. This is only a sample

[datapythonista]

Thanks for the changes @ForTimeBeing

You should have git remotes for:

• origin: your fork
• upstream: this repo (pandas-dev/pandas)

Something like git remote add upstream [email protected]:pandas-dev/pandas.git should leave this correct if you cloned your fork, and the diff should work.

[ForTimeBeing]

Thanks for the changes @ForTimeBeing

You should have git remotes for:

* `origin`: your fork

* `upstream`: this repo (pandas-dev/pandas)

Something like git remote add upstream [email protected]:pandas-dev/pandas.git should leave this correct if you cloned your fork, and the diff should work.

I now have upstreams as well:

origin https://github.com/ForTimeBeing/pandas.git (fetch)
origin https://github.com/ForTimeBeing/pandas.git (push)
upstream [email protected]:pandas-dev/pandas.git (fetch)
upstream [email protected]:pandas-dev/pandas.git (push)

I am still getting the bad revision though

[datapythonista]

run git fetch upstream first

[simonjayhawkins]

@ForTimeBeing lgtm pending ci fixes

[simonjayhawkins]

@ForTimeBeing can you merge master to fix ci issues.

[WillAyd]

@ForTimeBeing can you try one more merge of master?

[jbrockmendel]

GH is showing me a zero-file diff. Have these changes already been merged?

[datapythonista]

I guess this has been addressed elsewhere. Closing.

[ForTimeBeing]

I apologize, I have not been around because of the holiday

Happy holidays everyone