Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: remove statsmodels/seaborn compat shims #29822

Merged
merged 4 commits into from
Nov 25, 2019
Merged

DEPR: remove statsmodels/seaborn compat shims #29822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3263a42
DEPR: remove statsmodels/seaborn compat shims
jbrockmendel Nov 24, 2019
c8f063b
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
jbrockmendel Nov 24, 2019
5f83add
update test
jbrockmendel Nov 24, 2019
bbf7044
blackify
jbrockmendel Nov 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pandas/core/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
)
from pandas.core.dtypes.missing import isna, isnull, notna, notnull

# TODO: Remove get_dummies import when statsmodels updates #18264
from pandas.core.algorithms import factorize, unique, value_counts
from pandas.core.arrays import Categorical
from pandas.core.arrays.integer import (
Expand Down Expand Up @@ -45,7 +44,6 @@
from pandas.core.indexes.period import Period, period_range
from pandas.core.indexes.timedeltas import Timedelta, timedelta_range
from pandas.core.indexing import IndexSlice
from pandas.core.reshape.reshape import get_dummies
from pandas.core.series import Series
from pandas.core.tools.datetimes import to_datetime
from pandas.core.tools.numeric import to_numeric
Expand Down
17 changes: 0 additions & 17 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,23 +96,6 @@
)


# see gh-16971
def remove_na(arr):
"""
Remove null values from array like structure.

.. deprecated:: 0.21.0
Use s[s.notnull()] instead.
"""

warnings.warn(
"remove_na is deprecated and is a private function. Do not use.",
FutureWarning,
stacklevel=2,
)
return remove_na_arraylike(arr)


def _coerce_method(converter):
"""
Install the scalar coercion methods.
Expand Down
6 changes: 0 additions & 6 deletions pandas/tests/series/test_missing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
date_range,
isna,
)
from pandas.core.series import remove_na
import pandas.util.testing as tm


Expand Down Expand Up @@ -48,11 +47,6 @@ def _simple_ts(start, end, freq="D"):


class TestSeriesMissingData:
def test_remove_na_deprecation(self):
# see gh-16971
with tm.assert_produces_warning(FutureWarning):
remove_na(Series([]))

def test_timedelta_fillna(self):
# GH 3371
s = Series(
Expand Down