-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: change pd.concat sort=None to sort=False #29786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ctx = tm.assert_produces_warning(None, check_stacklevel=False) | ||
|
||
with ctx: | ||
with tm.assert_produces_warning(None, check_stacklevel=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We fail on warnings now right (?). I think could probably get rid of this altogether
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we fail on warnings for all builds, or just the one?
Co-Authored-By: Tom Augspurger <[email protected]>
thanks @jbrockmendel |
No description provided.