Reenabled no-unused-function in setup.py #29767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,10 +95,6 @@ cdef class _NaT(datetime): | |||
| # higher than np.ndarray and np.matrix | |||
| __array_priority__ = 100 | |||
|
|
|||
| def __hash__(_NaT self): | |||
| # py3k needs this defined here | |||
| return hash(self.value) | |||
There was a problem hiding this comment.
are you sure this can be removed? (do you know why?)
There was a problem hiding this comment.
There are two __hash__ definitions for this class so I suppose the second one takes priority
There was a problem hiding this comment.
Ah, that's a good reason to remove it ;)
jreback
reviewed
Nov 21, 2019
| @@ -1406,59 +1406,6 @@ cdef inline StringPath _string_path(char *encoding): | |||
| # Type conversions / inference support code | |||
|
|
|||
|
|
|||
| cdef _string_box_factorize(parser_t *parser, int64_t col, | |||
There was a problem hiding this comment.
this is completely unused?
There was a problem hiding this comment.
Yea this is the only thing that appears in a grep of _libs
$ grep -nr "_string_box_factorize" pandas/_libs
pandas/_libs/parsers.pyx:1409:cdef _string_box_factorize(parser_t *parser, int64_t col,cdef as well so can't be called from outside of there
|
looks like a nice cleanup |
|
thanks @WillAyd |
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Nov 25, 2019
…ndexing-1row-df * upstream/master: (185 commits) ENH: add BooleanArray extension array (pandas-dev#29555) DOC: Add link to dev calendar and meeting notes (pandas-dev#29737) ENH: Add built-in function for Styler to format the text displayed for missing values (pandas-dev#29118) DEPR: remove statsmodels/seaborn compat shims (pandas-dev#29822) DEPR: remove Index.summary (pandas-dev#29807) DEPR: passing an int to read_excel use_cols (pandas-dev#29795) STY: fstrings in io.pytables (pandas-dev#29758) BUG: Fix melt with mixed int/str columns (pandas-dev#29792) TST: add test for ffill/bfill for non unique multilevel (pandas-dev#29763) Changed description of parse_dates in read_excel(). (pandas-dev#29796) BUG: pivot_table not returning correct type when margin=True and aggfunc='mean' (pandas-dev#28248) REF: Create _lib/window directory (pandas-dev#29817) Fixed small mistake (pandas-dev#29815) minor cleanups (pandas-dev#29798) DEPR: enforce deprecations in core.internals (pandas-dev#29723) add test for unused level raises KeyError (pandas-dev#29760) Add documentation linking to sqlalchemy (pandas-dev#29373) io/parsers: ensure decimal is str on PythonParser (pandas-dev#29743) Reenabled no-unused-function (pandas-dev#29767) CLN:F-string in pandas/_libs/tslibs/*.pyx (pandas-dev#29775) ... # Conflicts: # pandas/tests/frame/indexing/test_indexing.py
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a flag that was disabled 4 years ago in e9fde88 but maybe worth reconsidering, even though we don't fail on warnings for extensions in CI
This yielded the following on master:
I'm not sure what the
memview_set_objectandmemview_get_objectcomplaints are coming from just yet, but the rest are cleaned up in this PR