Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN:F-strings #29662

Merged
merged 1 commit into from
Nov 16, 2019
Merged

CLN:F-strings #29662

merged 1 commit into from
Nov 16, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 16, 2019 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

ref #29547

@ShaharNaveh ShaharNaveh marked this pull request as ready for review November 16, 2019 18:44
@ShaharNaveh
Copy link
Member Author

ShaharNaveh commented Nov 16, 2019 •
edited
Loading

How this failed test related to any of my changed files?
Can any of the devs help me out?

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 16, 2019
@jreback jreback added this to the 1.0 milestone Nov 16, 2019
@jreback jreback merged commit 09e16d7 into pandas-dev:master Nov 16, 2019
@jreback
Copy link
Contributor

jreback commented Nov 16, 2019

thanks!

@ShaharNaveh ShaharNaveh deleted the CLN-fstring-compact branch November 16, 2019 20:40
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@ShaharNaveh
F-strings (pandas-dev#29662)
dd790e8
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
F-strings (pandas-dev#29662)
feef464
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
F-strings (pandas-dev#29662)
176345b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaharNaveh @jreback