Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: filter warnings for is_extension_type deprecation #29549

Merged
merged 1 commit into from
Nov 11, 2019
Merged

TST: filter warnings for is_extension_type deprecation #29549

merged 1 commit into from
Nov 11, 2019

Conversation

jorisvandenbossche
Copy link
Member

Follow up on #29457

@jorisvandenbossche jorisvandenbossche added Deprecate Functionality to remove in pandas Testing pandas testing functions or related to the test suite labels Nov 11, 2019
@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Nov 11, 2019
@jorisvandenbossche
Copy link
Member Author

cc @jbrockmendel

jorisvandenbossche
jorisvandenbossche commented Nov 11, 2019
View reviewed changes
pandas/tests/dtypes/test_common.py
@pytest.mark.parametrize(
"check_scipy", [False, pytest.param(True, marks=td.skip_if_no_scipy)]
)
def test_is_extension_array_dtype(check_scipy):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy pasted the original is_extension_type to test is_extension_array_dtype, as that is going to replace it and was not yet tested here (so when cleaning this up, can simply remove the above is_extension_type test)

@jbrockmendel
Copy link
Member

I'm surprised we dont have better tests for is_extension_array_dtype. LGTM.

@TomAugspurger TomAugspurger mentioned this pull request Nov 11, 2019
Merged
TomAugspurger
TomAugspurger approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we dont have better tests for is_extension_array_dtype.

What's this referring to?

@jbrockmendel
Copy link
Member

What's this referring to?

the need for test_is_extension_array_dtype this implements

@TomAugspurger
Copy link
Contributor

I assume it's verifying that is_extension_array_dtype is indeed a drop-in replacement for all the (tested) cases of is_extension_dtype. Some are probably duplicative.

@TomAugspurger TomAugspurger merged commit f4098c3 into pandas-dev:master Nov 11, 2019
@jorisvandenbossche jorisvandenbossche deleted the depr-warning-extension-type branch November 12, 2019 07:19
@jorisvandenbossche
Copy link
Member Author

I assume it's verifying that is_extension_array_dtype is indeed a drop-in replacement for all the (tested) cases of is_extension_dtype.

Yes, but Brock's comment was about that this was needed, because is_extension_array_dtype did not yet have its own dedicated tests in test_common.py (it has some indirect tests in the extension array tests)

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@jorisvandenbossche
TST: filter warnings for is_extension_type deprecation (pandas-dev#29549
cbdee4c 
)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jorisvandenbossche @proost
TST: filter warnings for is_extension_type deprecation (pandas-dev#29549
72b6f5c 
)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jorisvandenbossche @proost
TST: filter warnings for is_extension_type deprecation (pandas-dev#29549
2a8aa32 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisvandenbossche @jbrockmendel @TomAugspurger