-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes NumericIndex constructor dtype aware #29529
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5bd9720
adds test case
oguzhanogreden 5ad038f
Format file
oguzhanogreden d620c51
Fixes #29526
oguzhanogreden efc846d
Move tests
oguzhanogreden a59a945
Suggested improvements
oguzhanogreden 5c7c65c
Does not rely on explicit arguments
oguzhanogreden 9ab3596
Test directly, second pass
oguzhanogreden 14e4e03
Adds what's new entry
oguzhanogreden 68fe304
Remove tailing whitespace in whatsnew entry
oguzhanogreden 458c25e
Move string check into Index._coerce_to_ndarray
oguzhanogreden 1df13c0
Reverts 458c25e89 and 5c7c65c5e
oguzhanogreden e6d5f6b
Fix formatting
oguzhanogreden a51bcec
Fix formatting in test_numeric.py
oguzhanogreden 13bda84
Moves _coerce_to_ndarray definition to NumericIndex
oguzhanogreden 60b4f7b
Adds type hint for dtype and requires it
oguzhanogreden b41893d
Adds docstring
oguzhanogreden c9db704
Fixes typo in docstring
oguzhanogreden 5603e0f
Remove coerce_to_ndarray, add to __new__
oguzhanogreden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hah, this is what we had quite some time ago. thanks