Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: de-duplicate _check_dummy #29520

Merged
merged 2 commits into from
Nov 11, 2019
Merged

REF: de-duplicate _check_dummy #29520

merged 2 commits into from
Nov 11, 2019

Conversation

jbrockmendel
Copy link
Member

independent of #29502. After both this and that there will be another de-duplication pr.

@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Nov 10, 2019
gfyoung
gfyoung approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was easy 😄

I would want to add some newlines between the if-statements for readability, though that would no longer make it a pure refactoring. So, not a deal breaker.

@gfyoung gfyoung added this to the 1.0 milestone Nov 10, 2019
@jreback jreback merged commit e8e22d4 into pandas-dev:master Nov 11, 2019
@jreback
Copy link
Contributor

jreback commented Nov 11, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the red5 branch November 11, 2019 15:23
keechongtan added a commit to keechongtan/pandas that referenced this pull request Nov 11, 2019
@keechongtan
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
3e847e9 
…ndexing-1row-df

* upstream/master: (109 commits)
  stronger typing in libreduction (pandas-dev#29502)
  API: rename labels to codes (pandas-dev#29509)
  CLN: remove unnecessary type checks (pandas-dev#29517)
  implement _BaseGrouper (pandas-dev#29520)
  CLN: F-string formatting in pandas/_libs/*.pyx (pandas-dev#29527)
  Fixed more SS03 errors (pandas-dev#29540)
  consolidate dim checks (pandas-dev#29536)
  REF: separate out _get_cython_func_and_vals (pandas-dev#29537)
  remove unnecessary exception (pandas-dev#29538)
  TST:Add test to check single category col returns series with single row slice (pandas-dev#29521)
  Make color validation more forgiving (pandas-dev#29122)
  DOC: update bottleneck repo and documentation urls (pandas-dev#29516)
  TST: add test for df construction from dict with tuples (pandas-dev#29497)
  add test for pd.melt dtypes preservation (pandas-dev#29510)
  updated DataFrame.equals docstring (pandas-dev#29496)
  Resolved merge conflicts (pandas-dev#29506)
  DOC: Improved pandas/compact/__init__.py (pandas-dev#29507)
  DOC: Update performance comparison section of io docs (pandas-dev#28890)
  TST: add test for df.where() with category dtype (pandas-dev#29454)
  DOC: Fix docs on merging categoricals. (pandas-dev#28185)
  ...
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@jbrockmendel
implement _BaseGrouper (pandas-dev#29520)
6c5e719
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
implement _BaseGrouper (pandas-dev#29520)
a59ee93
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
implement _BaseGrouper (pandas-dev#29520)
2fabd70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @gfyoung